Open
Conversation
adamjohnwright
previously approved these changes
Feb 11, 2026
…/release-orthoinference into feature/ensembl-ref-db
adamjohnwright
requested changes
Mar 17, 2026
Contributor
adamjohnwright
left a comment
adamjohnwright
left a comment
There was a problem hiding this comment.
"The new code adds imports for FileNotFoundException and JSONParser/ParseException. I'd want to verify that failures in fetchSchema or
fetchOrCreateEnsemblDbInstance (e.g., missing refdb.json, malformed JSON, DB query returning unexpected results) produces clear error messages rather than opaque stack traces." Claude.
I agree that, when possible, we should add proper error messages. If this is easy to do please do.
adamjohnwright
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Species.json and the inference code so it no longer creates reference databases for EnsEMBL.
Instead it pulls the EnsEMBL reference databases that already exist in the MySQL release database (derived from gk_central). There are 3 EnsEMBL reference databases that are needed for inference -- main, protist, and fungi.
It also pulls "alternative" reference databases from the release database if it already exists and only creates it if it doesn't exist.